document that chunkSize must be positive #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there are some people that say 0 is positive, so I would like to see a change to "greater than zero". On the other hand, the doc for chunk is not that great overall, maybe you could revamp the complete doc. |
There's an assert(chunkSize != 0) in the constructor which needs to be documented.
done
not right now |
|
Auto-merge toggled on |
burner
added a commit
that referenced
this pull request
Dec 7, 2015
document that chunkSize must be positive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an assert(chunkSize != 0) in the constructor which needs to be
documented.
https://issues.dlang.org/show_bug.cgi?id=10087